letsencrypt / letsencrypt/boulder

Move WrappedMap upstream into borp

Open
#8,875 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

In #4559 / #4585 we added a WrappedMap that annotates DB error messages with the table that was being worked on.

In the time since then we've forked gorp into borp, which we maintain. We should move this behavior of annotating table names upstream so we have one fewer layer of wrappers around our database.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating WrappedMap and tracing where it wraps database errors, then inspect the borp fork's database error handling. The work is done when table-name annotation lives in borp and Boulder no longer needs the extra wrapper; no specific files or tests are named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.