letsencrypt / letsencrypt/boulder

Address GHA prompting workflows duplicate comment behavior

Open
#8,862 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

We use workflows that recognize certain types of changes and add comments to prompt for specific actions ( see https://github.com/letsencrypt/boulder/blob/main/.github/workflows/cps-review.yml, and https://github.com/letsencrypt/boulder/blob/main/.github/workflows/issue-for-sre-handoff.yml ).

When a WIP pull request is marked ready-for-review, these workflows can double-comment.

There may be other cases where duplication can happen. Let's see if we can de-duplicate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review .github/workflows/cps-review.yml and .github/workflows/issue-for-sre-handoff.yml, starting with the workflow behavior when a WIP pull request becomes ready for review. Check for other paths that can produce duplicate prompt comments and verify that each applicable action results in a single comment.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.