letsencrypt / letsencrypt/boulder

ratelimits: Consider simplifying Batch and Non-Batch methods into a single variadic method

Open
#8,509 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the discussion in pull request 8503, especially comment r2578359809, since the issue contains no implementation or test locations. Determine whether Batch and Non-Batch rate-limit methods should be consolidated and what behavior must remain unchanged; the issue is done only once that design is agreed and the relevant callers and tests are updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.