letsencrypt / letsencrypt/boulder
Export grpc.Checker for compile-time interface checks of *SQLStorageAuthority, *SQLStorageAuthorityRO, and *RegistrationAuthorityImpl
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
Today we're enforcing that these implementations satisfy the grpc.checker interface conventionally, which places the onus on the reviewer. It would be much easier to have the compiler check this at compile time vis-a-vis var _ grpc.Checker = &RegistrationAuthorityImpl{}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find the grpc.Checker definition and the implementations named in the issue: *SQLStorageAuthority, *SQLStorageAuthorityRO, and *RegistrationAuthorityImpl. Confirm how the grpc package exposes related interfaces, then add compile-time checks and verify that the relevant Go packages compile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100