letsencrypt / letsencrypt/boulder
grpc: Only set overall health inside of long running checks
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
[!WARNING]
Only complete this once SRE is no longer checking consul health for thesa.StorageAuthorityandsa.StorageAuthorityReadOnly.
In #8254 (solving #8227) we start setting the overall server health for long running checks instead of a specific service. We configure all grpc clients to start checking the overall health. Now we should remove the service parameter from the long running check.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the changes described in #8254 and trace the gRPC long-running health check and overall server health setup. Confirm when SRE no longer checks Consul health for sa.StorageAuthority and sa.StorageAuthorityReadOnly, then remove the service parameter from the long-running check and verify that configured clients still use overall health.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100