letsencrypt / letsencrypt/boulder

sa: More efficient maps in authz getting funcs

Open
#8,111 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

GetAuthorizations2, GetValidAuthorizations2, and GetValidOrderAuthorizations2 all construct and return maps of authzs. These might be refactorable so that we can pass less data over gRPC.

This was originally noted in a TODO from #7646.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading GetAuthorizations2, GetValidAuthorizations2, and GetValidOrderAuthorizations2, then review the TODO from #7646 and trace their gRPC callers. Determine whether the returned authorization maps can be reduced while preserving behavior; done means less data is passed over gRPC and the existing tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grpc
Domain
api, backend, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.