letsencrypt / letsencrypt/boulder
ra: Add error value & conditions to NewRegistrationAuthorityImpl
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
ra.NewRegistrationAuthorityImpl takes some arguments that are pointers, and could be nil (e.g. limiter). It currently does not return an error. We should add an error value, return errors when passed nils for these arguments, and update calling functions to handle errors.
Discussed in: https://github.com/letsencrypt/boulder/pull/7858/files#r1906117221
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ra.NewRegistrationAuthorityImpl and inspect the calling functions that use it, then review the linked discussion for context on the proposed API change. Add error returns for nil pointer arguments such as limiter and update each caller to handle them; done means nil inputs no longer proceed silently and callers compile with the new return value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100