letsencrypt / letsencrypt/boulder
test: More integration tests for rate limits
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
The ratelimits package has excellent test coverage, but we have relatively few tests that check rate limit behaviour end-to-end. Let's add more cases to test/integration/ratelimit_test.go.
For example, although ratelimits/transaction_test.go tests that transactions get created as specified, we don't necessarily test that those functions' callers are producing the set of transactions we expect them to.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/integration/ratelimit_test.go and compare its existing end-to-end cases with ratelimits/transaction_test.go, which covers transaction creation. Add integration cases that verify callers produce the expected rate-limit transactions, then confirm the integration test file passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100