letsencrypt / letsencrypt/boulder
wfe2: Add unit test for refunding rate limits in NewOrder
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
wfe.NewOrder refunds any increments to NewOrder rate limits if order creation fails (due to a reason other than rate limits). This behaviour is not currently unit tested, and should be.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the wfe.NewOrder entry point and its existing unit tests. Add coverage for an order-creation failure caused by something other than rate limits, and verify that any NewOrder rate-limit increments are refunded; run the relevant wfe unit tests to confirm the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100