letsencrypt / letsencrypt/boulder
ratelimits: Test loading & parsing rate limits individually
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
Tests in the ratelimits package were written against the combined loadAndParse... functions. Now that those functions' logic is being split up (e.g. #7869), the tests should be too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the ratelimits package tests and the loadAndParse... functions, then compare the split logic introduced in #7869. Update the tests so loading and parsing are exercised individually, and run the ratelimits package tests to confirm the separate paths are covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100