letsencrypt / letsencrypt/boulder

RA and CA logs differ for CertProfileName and CertProfileHash

Open
#7,848 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

starter
Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

There's a discrepancy between the field names that the RA and CA use for multiple certificate profiles.

Example:

boulder-ra[50313]: 9IC1bQA [AUDIT] Certificate request - successful JSON={"ID":"X","Requester":123,"OrderID":456,"SerialNumber":"030000000000000000000000000000000000","VerifiedFields":["subject.commonName","subjectAltName"],"CommonName":"example.net","Names":["example.net"],"NotBefore":"2024-11-26T15:00:00Z","NotAfter":"2025-02-24T15:00:00Z","RequestTime":"2024-11-26T16:00:00.00000014Z","ResponseTime":"2024-11-26T16:00:00.000000Z","Authorizations":{"example.net":{"ID":"789","ChallengeType":"http-01"}},"CertProfileName":"defaultBoulderCertificateProfile","CertProfileHash":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}
boulder-ca[2619024]: v-OalA4 [AUDIT] Signing cert JSON={"IssuanceRequest":{"PublicKey":"aabc123","SubjectKeyId":"123","Serial":"030000000000000000000000000000000000","NotBefore":"2024-11-26T15:00:00Z","NotAfter":"2025-02-24T15:00:00Z","CommonName":"example.net","DNSNames":["example.net"],"IncludeMustStaple":false,"IncludeCTPoison":false},"Issuer":"E6","OrderID":789,"Profile":"defaultBoulderCertificateProfile","ProfileHash":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa","Requester":123,"Result":{}}

Here's a slightly better view of just the JSON portion of the log.
RA:

{
  "ID": "X",
  "Requester": 123,
  "OrderID": 456,
  "SerialNumber": "030000000000000000000000000000000000",
  "VerifiedFields": [
    "subject.commonName",
    "subjectAltName"
  ],
  "CommonName": "example.net",
  "Names": [
    "example.net"
  ],
  "NotBefore": "2024-11-26T15:00:00Z",
  "NotAfter": "2025-02-24T15:00:00Z",
  "RequestTime": "2024-11-26T16:00:00.00000014Z",
  "ResponseTime": "2024-11-26T16:00:00.000000Z",
  "Authorizations": {
    "example.net": {
      "ID": "789",
      "ChallengeType": "http-01"
    }
  },
  "CertProfileName": "defaultBoulderCertificateProfile",
  "CertProfileHash": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
}

CA:

{
  "IssuanceRequest": {
    "PublicKey": "aabc123",
    "SubjectKeyId": "123",
    "Serial": "030000000000000000000000000000000000",
    "NotBefore": "2024-11-26T15:00:00Z",
    "NotAfter": "2025-02-24T15:00:00Z",
    "CommonName": "example.net",
    "DNSNames": [
      "example.net"
    ],
    "IncludeMustStaple": false,
    "IncludeCTPoison": false
  },
  "Issuer": "E6",
  "OrderID": 789,
  "Profile": "defaultBoulderCertificateProfile",
  "ProfileHash": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
  "Requester": 123,
  "Result": {}
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the audit-log field definitions at the cited locations in ra/ra.go and ca/ca.go. Trace how CertProfileName/CertProfileHash and Profile/ProfileHash are serialized, then align the field names so equivalent RA and CA log data uses consistent names. Confirm the resulting audit log JSON matches between the two services.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability-sre
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.