letsencrypt / letsencrypt/boulder
Clean up NoWaitForReady
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
In https://github.com/letsencrypt/boulder/issues/6834 we added a config NoWaitForReady that allows gRPC requests to instantly error when there are no backends available (vs waiting for a backend and eventually reporting a timeout). That config is now enabled in prod. We should deprecate and ignore it, effectively never waiting for readiness. As part of that process we should also search the codebase for FailFast (which is the older gRPC terminology for the feature) and clean up relevant comments.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for NoWaitForReady and the older gRPC term FailFast, then trace the related configuration and request handling. Deprecate and ignore NoWaitForReady so requests do not wait for readiness, and clean up relevant comments; done when the existing behavior and references reflect that configuration no longer controls waiting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100