letsencrypt / letsencrypt/boulder
Move account key checks from WFE to RA
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
The RA should perform any checks (is it weak? is it in the blocked-keys list? etc) on the newly-supplied key, rather than leaving that to the WFE.
Originally posted by @aarongable in https://github.com/letsencrypt/boulder/pull/7735#discussion_r1823376809
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the WFE and RA account-key handling and the discussion in pull request 7735, which is the issue's source. Trace where weak-key and blocked-key checks currently occur. Done means the RA performs all checks on newly supplied keys and the WFE no longer performs them, with relevant tests updated or added.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100