letsencrypt / letsencrypt/boulder
Refactor CA tests to be table-driven
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
In #7700 we removed the RejectLongCommonName test case, but we'd still like to test that the case is handled correctly; "correctly" just no longer means rejecting the CSR.
To get there, we should refactor these CA tests to be table-driven, which will be tidier and give us an elegant way to specify the behaviour we expect.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the CA test containing the removed RejectLongCommonName case and compare the referenced #7700 diff. Refactor the relevant cases into a table-driven form that expresses expected behavior, including handling the long common name; done means the CA tests pass and that case is covered again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- security, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100