letsencrypt / letsencrypt/boulder
test/certs/generate.sh: should regenerate when new service names are added
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
After a recent pull, I was getting errors running the integration tests because test/certs/ipki/sfe.boulder/ didn't exist. That's because sfe.boulder was recently added to the list of services, but generate.sh doesn't regenerate the certificates if the ipki directory already exists: https://github.com/letsencrypt/boulder/blob/161ca1ed7843c2f4f1205dfa107f75f6abc276fe/test/certs/generate.sh#L70-L74
This error will affect anyone running Boulder, any time we add services to the internal PKI. We should improve the script so it automatically adds new services; for instance we could make the script check the existence of each service name's directory, rather than ipki overall.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/certs/generate.sh, especially the referenced logic around lines 70–74, and inspect how service names map to directories under test/certs/ipki/. Run the integration-test certificate generation path with an existing ipki directory; done means newly added service directories, including sfe.boulder, are generated automatically.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- security, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100