letsencrypt / letsencrypt/boulder
Add a method to db.Executor instances passed inside of db.WithTransaction
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
We have some functions inside of model.go which should only be called inside of a transaction but absolutely could be called outside of a transaction if the caller wasn't careful.
Modify db.WithTransaction func() to accept an Executor which meets the same interface but also includes a method that differentiates it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading model.go and the db.WithTransaction implementation to understand how db.Executor instances are passed into transaction-scoped functions. Determine the interface distinction needed for transaction-only calls and verify that callers can no longer use those functions outside a transaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- database
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100