letsencrypt / letsencrypt/boulder
Refactor WFE.SendError to accept just an error or problem, not both
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
SendError accepting both a problem and an error has been flagged as being non-idiomatic and leads to adjacent code being written in a non-idiomatic fashion. This has been flagged in #7298 and #7283.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating WFE.SendError and tracing its callers in the Boulder repository. Read the related discussions in #7298 and #7283 for context, then update the affected callers so the function accepts only an error or a problem; done means the refactor is consistent across its uses and the Go tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100