letsencrypt / letsencrypt/boulder
Change usage of time.Now() in tests to fakeclock.Now() where possible
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
Boulder tests mostly use fakeclock whose time only progresses when told to do to. Two adjacent calls to clk.Now() will always return the same value.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search Boulder’s Go test files for time.Now() and inspect nearby fakeclock usage, starting with tests that already use fakeclock. Update only eligible test calls and run the affected Go tests; done means the applicable tests use fakeclock.Now() while preserving cases that require independently advancing time.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100