letsencrypt / letsencrypt/boulder

sa: implement retry of certain operations that we know are safe to retry

Open
#6,912 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

For instance, SELECT and BEGIN TRANSACTION are generally safe in our codebase to automatically retry.

We sometimes get errors from the database driver level that the driver does not know it is safe to retry, because a connection was broken after request bytes were sent. However, we can know they're safe and retry them.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how database driver errors are handled and where existing retry decisions are made. Determine how the code identifies safe operations such as SELECT and BEGIN TRANSACTION, then define completion as retrying those operations when request bytes may already have been sent without retrying unsafe operations.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, database
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.