letsencrypt / letsencrypt/boulder
Rework admin-revoker and orphan-finder to take *prometheus.Registerer
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
Admin-revoker and orphan-finder are short lived processes that call TLS.Load(), but as of PR 6836 TLS.Load(scope) takes a *prometheus.Registerer. The Registerer requires a debug address that metrics will be exported on. In that PR, I used metrics.NoopRegisterer, but this should be changed.
It's conceivable that one day admin-revoker and orphan-finder will be batch jobs running in nomad and could be automatically scraped by prometheus.
Related to https://github.com/letsencrypt/boulder/issues/6829
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the admin-revoker and orphan-finder entry points and their TLS.Load calls, then read PR 6836 and related issue 6829 for the existing Registerer pattern. Update these short-lived processes to accept a prometheus.Registerer instead of using metrics.NoopRegisterer, and verify that their metrics/debug address behavior matches the intended design.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, prometheus
- Domain
- backend, observability
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100