letsencrypt / letsencrypt/boulder
Reinstate TestAddPrecertificateStatusFail
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
In #6519, we're removing a unittest that spuriously breaks (it relied on a coincidental behavior of our indexes). It needs a refactoring in the SA to use an interface instead of *db.WrappedMap. This is a tracking issue for that refactoring and reinstating the test.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading #6519 and the SA code related to TestAddPrecertificateStatusFail, including its use of *db.WrappedMap. Refactor the SA to use an interface, then reinstate the unittest and verify that it no longer depends on coincidental index behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100