letsencrypt / letsencrypt/boulder
sql: suppress ordinary errors
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
During times of high load, we log a large number of error log lines like these:
[mysql] read ... i/o timeout
[mysql] unexpected EOF
These go through the mysql log adapter in cmd/shell.go. We can log thousands of these per minute, which suggests they would be better as a stat than as a log line. We should suppress these in the log adapter and add a stat for them (assuming there is no stat we can already gather).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in cmd/shell.go and inspect the mysql log adapter, then check whether an existing stat already captures the ordinary read timeout and unexpected EOF errors. Done means those errors are no longer emitted as individual log lines and an appropriate stat records them; verify the behavior with the relevant project tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100