letsencrypt / letsencrypt/boulder
va: restrict logging of too-long redirect targets
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
Right now the va rejects too-long redirect targets, but will log the whole thing. We should truncate the logged URL to our max size, so we don't make our logs too big.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the va code that rejects overlong redirect targets and logs the rejected URL. Trace how the maximum size is defined and how the rejection is tested. Done means the logged URL is capped at that maximum while the rejection behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100