letsencrypt / letsencrypt/boulder
Replace usage of berrors.ServerInternal
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
Follow up to #6050. Any plain error returned via gRPC will get translated by WFE into a JSON Problem Document with "type": "ietf...serverInternal"), regardless of whether we wrap it in berrors.ServerInternal. We should eliminate use of berrors.ServerInternal since it's redundant.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for uses of berrors.ServerInternal, then trace the gRPC error handling through the WFE. Confirm how plain errors are translated into JSON Problem Documents and identify all affected callers. Done means the redundant wrapper usage is removed without changing the resulting serverInternal responses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100