letsencrypt / letsencrypt/boulder

Add lints and metrics to show that linting works

Open
#5,755 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

We can add a custom lint which, for example, rejects all certs for "lintreject.radianttest.org". Then we can have our automated issuance testing try to issue for that name, and confirm that it gets rejected by pre-issuance linting.

We should also add a metric which counts how often certs are rejected due to failing pre-issuance linting, and alert if that metric ever goes above zero (or above whatever the rate of the automated testing above is).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the automated issuance testing mentioned in the issue and the pre-issuance linting path it exercises. Add the rejection case for lintreject.radianttest.org and verify issuance is rejected, then expose the rejection count as a metric and configure an alert against the automated test rate.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability, security, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.