letsencrypt / letsencrypt/boulder

Increment stat on failure to get CT log info

Open
#5,705 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

If there's an error getting info for a CT log, we can hit this error case:

https://github.com/letsencrypt/boulder/blob/4205400a98c8285cccd478cb99e044d75f48e36d/ctpolicy/ctpolicy.go#L96-L100

This can happen, for instance, if we need to write to a temporal shard of a log, and the appropriate temporal shard isn't in the config. When that happens, we should increment a stat. Once the stat is implemented, we should follow up by adding a Prometheus alert.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at ctpolicy/ctpolicy.go lines 96-100, where the CT log information lookup error is handled. Trace the existing statistics and Prometheus alert configuration to add a counter for this failure, then follow up with the alert described in the issue. Done means the failure increments the stat and the related alert is configured.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.