letsencrypt / letsencrypt/boulder

Add a full db.mockWrappedMap to sa/database tests

Open
#5,248 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

@aarongable pointed out in #5235 that this kind of code duplication really suggests that what we actually need is a full db.mockWrappedMap

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the sa/database tests and the referenced discussion in pull request #5235 to understand the duplicated mock behavior. Trace the existing db.mockWrappedMap usage, then define completion as providing a full mockWrappedMap for the sa/database tests and replacing the relevant duplication.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.