letsencrypt / letsencrypt/boulder

sa: centralize lists of columns for object types

Open
#4,899 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

In #4880, we fixed an issue where the list of columns for a certificateStatus was different in ocsp-updater than it was in the SA. We should make the SA the authoritative source of column lists for objects, and make sure that any place we explicilty enumerate columns (rather than leaving it to Gorp), we get the list from the SA package.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the SA package and the code in ocsp-updater related to the certificateStatus column-list discrepancy from #4880. Search the repository for places that explicitly enumerate object columns rather than relying on Gorp. Done means those lists consistently come from the SA package, with no duplicate authoritative definitions remaining.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.