letsencrypt / letsencrypt/boulder
Store table names for types in `initTable` to use for `db.ErrDatabaseOp` instances
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.8k
- Forks
- 649
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 24
Description
In https://github.com/letsencrypt/boulder/pull/4585 we determine the table name for a db.ErrDatabaseOp generated during a Get, Insert, Update, or Delete based on the type of a holder argument interface{}.
This works pretty well but doesn't give the true table name based on how Gorp will map that type to a table.
@rolandshoemaker suggests:
Instead of deriving the table from the type, we could alter the
initTablesmethod to record the actual type <-> table mapping somewhere and use that here so we get the specific table name.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the initTables method and the code that creates db.ErrDatabaseOp during Get, Insert, Update, and Delete. Review pull request 4585 for the current type-based table lookup and identify where the actual Gorp type-to-table mapping can be retained. Done means database-operation errors use the mapped table name rather than deriving it from the holder type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100