less / less/less.js

Mixin followed by !important is not correctly compiled

Open
#3,747 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17k
Forks
3.4k
Avg merge
7h 42m
Merged PRs (30d)
26

Description

Hi,

I have noticed a inconsistency between the documentation and the functioning of less.

In the documentation, adding !important to the mixin should result in the !important being added to all the css declarations inside the mixin. However, this is not the case. Upon compiling, the css does not contain the !important.

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the documented mixin behavior with a minimal Less example and compare the compiled CSS with the expected declarations. Trace the mixin compilation path, then add a regression test showing that applying !important to the mixin adds it to every declaration inside the mixin.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.