How to handle mixed unit math
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17k
- Forks
- 3.4k
- Avg merge
- 7h 42m
- Merged PRs (30d)
- 26
Description
div {
@value: 1px;
a: @value * 1rem; // 1px - ok
b: @value * 1px * 1rem; // 1px - ok
d: @value / 1px; // 1px - ok
c: @value / 1px * 1rem; // 1rem - unexpected
e: @value / 1px + 0rem; // 1rem - unexpected
}
c and d results above contradict with http://lesscss.org/features/#features-overview-feature-operations stating the result should have a leftmost unit of an expression (i.e. all expressions above should produce 1px). Tests cover only a / b / c expression which accidentally produces the expected result.
Related to #2418 and #2472.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the mixed-unit examples in the issue and read the operations section of the Less documentation. Extend the existing coverage in test/less/variables.less beyond the a / b / c case, then verify that the tests and documented leftmost-unit behavior agree for the c and e expressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- compilers, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100