less / less/less.js

Important on mixin not working on embedded media queries.

Open
#2,917 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
17k
Forks
3.4k
Avg merge
7h 42m
Merged PRs (30d)
26

Description

This:

.mixin() {
  .classname {
    color: green;
    @media screen and(max-width: 500px) {
      color: red;
    }
  }
}
.mixin() !important;

Generates:

.classname {
  color: green !important;
}
@media screen and (max-width: 500px) {
  .classname {
    color: red;
  }
}

Shouldn't the media query have color: red !important ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by compiling the Less example from the issue and compare the generated CSS with the expected output. Trace how !important is applied to mixin output and how nested media queries are emitted. Done means the declaration inside the embedded media query also includes !important.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.