data-uri function uses path of data-uri call, not the string with the path to the file in.
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 17k
- Forks
- 3.4k
- Avg merge
- 7h 42m
- Merged PRs (30d)
- 26
Description
from https://github.com/less/less.js/issues/2541 but I've seen this in projects
// mixins.less
.background(@image) {
background-image: data-uri(@image);
}
// app/content/button.less
button {
.background("images/btn.jpg");
}
I would expect the image to be fetched from app/content/images/btn.jpg but it is fetched from images/btn.jpg.
I welcome feedback on whether this is a breaking change (warranting a major up) or a bug fix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the data-uri call from mixins.less and app/content/button.less, then trace the data-uri implementation and its path-resolution entry point. Confirm whether the image is resolved relative to the mixin or the calling stylesheet; done means the documented expected path is used without breaking existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100