if env.paths is a string you get a misleading error
Open
Nobody has claimed this yet.
bug
low priority
- Dominant language
- JavaScript
- Stars
- 17k
- Forks
- 3.4k
- Avg merge
- 7h 42m
- Merged PRs (30d)
- 26
Description
Callback is never executed from the call to parse(). Same input parses correctly by @1.7.0 so it looks like a regression of some sort.
Stepping through revealed an exception caught at line 27 of input-visitor.js:
error: TypeError: Function.prototype.apply: Arguments list has wrong type
arguments: Array[0]
message: undefined
stack: undefined
type: "apply_wrong_args"
__proto__: TypeError
this.importCount is set to 1 at this point, so no termination. No further exceptions when continued from this point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue through the call to parse() using an env.paths string, then inspect input-visitor.js around line 27 where the exception is caught. Compare the behavior with version 1.7.0 and trace why the callback is not executed. Done means the input parses correctly and no misleading apply_wrong_args error is produced.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100