--include-path does not work with Rhino
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 17k
- Forks
- 3.4k
- Avg merge
- 7h 42m
- Merged PRs (30d)
- 26
Description
2 problems:
os.type()does not exist with Rhino (at least with the LESS CSS Compiler for Java). It seems it is specific to NodeJS, but I don't know Javascript enough to be sure.- when I fix the first point, I realize that the
less.Parser.fileLoader()function defined inrhino.jsdoes not handle the path setted by--include-path.
I am proposing a pull request to fix both.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with rhino.js and inspect the use of os.type() and less.Parser.fileLoader(). Trace how --include-path is passed into the Rhino file loader. Done means Rhino can run without the Node-specific call and resolves included files from the configured include path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100