Weired no unit Dimension comparison
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17k
- Forks
- 3.4k
- Avg merge
- 7h 42m
- Merged PRs (30d)
- 26
Description
It's probably not a issue at all, but I can't find any rationale why the things work as it do:
.mixin(@var) when (@var=42) {
.test {
pass: true;
}
}
Why can I call the code with .mixin(42em), .mixin(42ms), etc? I suppose it may be usefull to pass .mixin(4200%) but why do the test work on any unit?
When I change the || to && in the comparison code it breaks only mixins-guards tests which reproduce the described behavior
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/less/tree/dimension.js around line 95 and the mixins-guards tests linked in the issue. Reproduce the .mixin(42em) and .mixin(42ms) cases, then trace how dimension comparisons handle units. Done means the intended comparison behavior is established and the relevant tests reflect it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100