less / less/less.js

Extend all replacement in nested selector :not() does not work

Open
#1,680 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug medium priority
Dominant language
JavaScript
Stars
17k
Forks
3.4k
Avg merge
7h 42m
Merged PRs (30d)
26

Description

Extend all does not replace inside pseudoclasses such as :not.

Sample input:

a:not(tag1) {
    property: value;
}
replacement1:first:extend(tag1 all) {}

less.js output:

a:not(tag1) {
  property: value;
}

expected output:

a:not(tag1),
a:not(replacement1:first) {
  property: value;
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test entry point is named in the issue. Reproduce the provided nested :not() and :extend(... all) example in less.js, then trace selector extension handling and add a regression test whose output includes both the original selector and the replacement selector.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.