less / less/less.js

Extend all and leading/trailing combinators

Open
#1,642 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug medium priority
Dominant language
JavaScript
Stars
17k
Forks
3.4k
Avg merge
7h 42m
Merged PRs (30d)
26

Description

It is not possible to use leading or trailing combinator inside extend all. Combinators in the middle are compared while:

  • leading combinators are ignored
  • trailing combinators prevent matching.
a:first b:second  { property: value;}
a:first + b:second  { property: value;}

leading:extend(+ b:second all) {} // + is ignored
trailing:extend(a:first + all) {} // + prevents matching

compiles into:

a:first b:second,
a:first leading { // + was ignored match found 
  property: value;
}
a:first + b:second,
a:first + leading { // trailing is missing here
  property: value;
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the Less compiler logic for extend-all matching and compare its handling of leading, middle, and trailing combinators with the examples in the issue. Done means leading and trailing combinators are matched consistently and the shown output includes the trailing combinator case.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.