http://localhost:8081 absolute paths around the tests and browser test
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17k
- Forks
- 3.4k
- Avg merge
- 7h 42m
- Merged PRs (30d)
- 26
Description
As a developer, I did installation for all needed tools/software into virtual machine spinning with Vagrant Up and Virtual Box.
With my Vagrant settings I have other than localhost domain name (actually it is just an IP address), and because of rigid localhost:8081 domain into the script, browser tests are not going properly, example file.
I expect that domain name was taken from somewhere environment, or (but probably it would not be good) there would be replacement for relative paths (which I basically did to make it works).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/browser-test-prepare.js, especially lines 16–17, and inspect how the browser test server address is configured. Reproduce the tests with a non-localhost Vagrant IP or domain. Done means the browser tests no longer depend on a hardcoded localhost:8081 and still work with the default setup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing-qa, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100