less / less/less-plugin-clean-css

Sourcemaps broken in latest v1.6.0

Open
#42 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
193
Forks
41
Avg merge
7h 43m
Merged PRs (30d)
2

Description

The latest version of this plugin no longer allow sourcemaps to be generated correctly. According to the docs, in clean-css v4.0 and above they changed the api for using sourcemaps and passing the sourcemaps into the options as this plugin does no longer works.

If I understand correctly the sourcemaps need to be passed as a paramater into the minify() method instead. See docs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/clean-css-processor.js at the linked line and read the clean-css sourcemap documentation for the v4+ API. Verify how sourcemaps must be supplied to minify(), then confirm the plugin generates correct sourcemaps with the latest clean-css version.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.