less / less/less-meta

Should `:extend(.selector all)` flag be `!all`?

Open
#29 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
5
Forks
0
PR merge metrics
No merged PRs in 30d

Description

I realized I've felt this way for a while but haven't raised it as a specific issue.

I think we should change this...

.foo:extend(.bar all) {}

...to...

.foo:extend(.bar !all) {}  // !all flag

That is, it's long felt odd to me that all looks like a regular selector. I think it should be a flag, like !important. Obviously if we ever got around to implementing deep it would be the same way.

It would be trivial in the parser to make ! optional, and then later update docs to prefer it, but I'm wondering how others feel about it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue proposes changing the LESS syntax from all to !all and mentions the parser and documentation, but names no files or tests. First review how the parser handles :extend flags and how the syntax is documented; the work is only ready when the project agrees on the syntax and its scope.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.