lepoco / lepoco/wpfui

If implementing INavigationAware in a Page, the methods are being called twice, redundantly.

Open
#636 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
9.6k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

If implementing INavigationAware in a Page, the methods are being called twice, redundantly,
To reproduce this issue, I have inherited INavigationAware in the AllControlsPage under the Wpf.Ui.Gallery folder. Then, I have output some information in the OnNavigatedTo method, and this information is being output twice

To Reproduce

public partial class AllControlsPage : INavigableView , INavigationAware
{
public AllControlsViewModel ViewModel { get; }

public AllControlsPage(AllControlsViewModel viewModel)
{
    ViewModel = viewModel;
    DataContext = this;

    InitializeComponent();
}

public void OnNavigatedTo()
{
    Debug.WriteLine("==== NavigatedTo");
}
public void OnNavigatedFrom()
{

}

}

we can show debug output :
==== NavigatedTo
==== NavigatedTo****

Expected behavior

There is an error with INavigationAware on the page class

Screenshots

No response

OS version

window

.NET version

net7.0

WPF-UI NuGet version

github source code now

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AllControlsPage implementation in the Wpf.Ui.Gallery folder and inspect how its INavigationAware methods are reached during navigation. Reproduce the issue using the shown Debug.WriteLine in OnNavigatedTo, trace both calls through the navigation entry points, and consider the issue done when navigation invokes the method once.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.