lepoco / lepoco/wpfui

Dialog.ShowAndWaitAsync hideOnClick parameter gets overridden

Open
#370 0 comments 0 reactions 1 assignee View on GitHub

@pomianowski is already working on this.

Since Aug 30, 2022.

bug
Dominant language
C#
Stars
9.6k
Forks
1k
No merged PRs in 30d

Description

Describe the bug

image

Expected behavior
HideOnClick should be persisted through the call stack of ShowAndWaitAsync and all other method signatures.
An optional parameter with default to = false could do the trick along the different ShowAndWaitAsync() and Show() signatures.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.