Update `System.ValueTuple` dependency from `4.5.0` to `4.6.1`.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 9.6k
- Forks
- 1k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
A member of our community reported that their endpoint protection software flagged System.ValueTuple.dll as malicious, despite it being signed off by Microsoft, etc.
Given Microsoft has recently put out 4.6.1, maybe there was some issue with the file after all these years.
I've updated my subtree clone of Wpf.Ui to use 4.6.1 here and have encountered no ill effects or issues following this change.
To Reproduce
- Use Microsoft Defender for Cloud Apps
- Witness the apprent issue
Expected behavior
- Use any endpoint protection software
- Experience no issues with MSFT-signed dependencies
Screenshots
No response
OS version
Windows
.NET version
net462
WPF-UI NuGet version
4.0.0
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Wpf.Ui dependency declaration for System.ValueTuple and inspect how version 4.5.0 is referenced for the net462 package. Update the reference to 4.6.1, then build WPF UI and verify that the dependency is accepted without endpoint-protection warnings or regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100