lepoco / lepoco/wpfui

Wpf.Ui.Controls.NumberBox event ValueChanged called early

Open
#1,315 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
9.6k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

ValueChanged event is called before the binded value changes

To Reproduce

with this piece of code we can see that NumberBox.Value is the correct value but the binded value doesn't.

         <StackPanel Grid.Row="2" Margin="20" Grid.ColumnSpan="2">
            <ui:NumberBox Value="{Binding testValue}" ValueChanged="NumberBox_ValueChanged"  HorizontalAlignment="Left"/>
            <TextBlock x:Name="bugReport" TextWrapping="Wrap"/>
         </StackPanel>
      public double testValue { get; set; } = 10.12345567788;
      private void NumberBox_ValueChanged(object sender, System.Windows.RoutedEventArgs e) {
         if(bugReport == null)
            return;
         bugReport.Text += $" - {( (NumberBox)sender ).Value.ToString()} ({testValue})";
      }
Expected behavior

The event is called after the binded value is associated

Screenshots

image

OS version

Window 11

.NET version

.net 9.0

WPF-UI NuGet version

3.0.5

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the provided NumberBox XAML and C# handler, then trace the NumberBox ValueChanged implementation and its binding behavior. Done means the bound testValue is updated before ValueChanged observes it, while the existing reproduction behaves as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.