Switching theme from a different thread is raising an exception on Windows 10
@pomianowski is already working on this.
Since Apr 17, 2024.
- Dominant language
- C#
- Stars
- 9.6k
- Forks
- 1k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
If you attempt to call ApplicationThemeManager from a different thread a InvalidOperationException is raised detailing that "The calling thread cannot access this object because a different thread owns it.". This exception appears within the ApplyDefaultWindowBorder method of the ClientBorder control. This appears to be isolated to Windows 10 only, because of the operating version check before hand.
There is no guarantee the the ThemeChanged event was raised on the thread, so I only can think that we should be doing a thread safety check and ensuring that we are on the UI thread before updating the UI.
To Reproduce
- Assume that you are running on a variant of Windows 10.
- Access and call ApplicationThemeManager.Apply from a different thread other than the UI thread.
Expected behavior
It should be possible to switch theme from a different thread, ensuring that there were thread safety checks done at the place of applying the UI changes.
Screenshots
OS version
Windows 10 21H2
.NET version
.net 8.0
WPF-UI NuGet version
3.0.4
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.