leostera / leostera/rules_reason

Example out of date?

Open
#3 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug examples
Dominant language
Python
Stars
19
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Looks like the opam_package rule added a new argument, 'type', which is missing. It also seems like the available types won't support the format that cmdliner uses: tbz.

11:14 $ cd examples && bazel build ...
Starting local Bazel server and connecting to it...
...........
ERROR: /Users/josephprice/dev/github.com/ostera/rules_reason/examples/3rdparty/opam/deps.bzl:8:5: //external:opam.cmdliner: missing value for mandatory attribute 'type' in 'opam_package' rule
ERROR: /Users/josephprice/dev/github.com/ostera/rules_reason/examples/3rdparty/opam/deps.bzl:8:5: //external:opam.cmdliner: invalid value in 'type' attribute: has to be one of 'zip', 'jar', 'war', 'tar.gz', 'tgz', 'tar.bz2' or 'tar.xz' instead of ''
ERROR: error loading package 'external': Package 'external' contains errors
INFO: Elapsed time: 0.622s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with examples/3rdparty/opam/deps.bzl, especially the opam.cmdliner declaration at the reported line, and compare it with the opam_package rule's required attributes. Check how the example represents the tbz archive type, then rerun cd examples && bazel build ...; done means the example loads and builds without the reported attribute or archive-type errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.