leobalter / leobalter/DexterJS

Add XHR2 callback support

Open
#22 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
56
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Hello,

I started using DexterJS for testing my ajax requests, and I really enjoy it so far.
However, I am using JQuery 2 and I found out that the only callback supported in master is onreadystatechange. Unfortunately, JQuery2 wants to use onload and friends.

I quickly tweaked my local copy's __DexterStateChange to invoke onload when switching the state to DONE. That gets me going for now, but it is by no mean a clean solution. Proper support for the new callbacks would be awesome if someone fins the time to do it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the __DexterStateChange function mentioned in the issue and trace how it handles the DONE state and existing onreadystatechange callback. Identify the XHR2 callbacks JQuery 2 expects, then verify that they are invoked at the appropriate state transitions without breaking the current callback behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.