lelandrichardson / lelandrichardson/knockout-react

ideas.js code cleanup and more obvious name?

Open
#1 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
24
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Hey, there. I noticed that the ideas.js file has the ToDo... component embedded in it.
I also think that maybe 'ideas.js' is not an ideal name for helping people find the component part of your project.

It works great once the embedded ToDo component is removed.

Are you planning on updating/cleaning this up? :) Thanks for sharing this!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ideas.js and inspect the embedded ToDo component. Determine the intended component boundary and whether the file name should be changed; done means the ToDo component is no longer embedded there and the resulting name clearly identifies its purpose.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.