leinardi / leinardi/FloatingActionButtonSpeedDial

TalkBack reads the label text twice

Open
#193 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.5k
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Step 1: Are you in the right place?
  • I have verified there are no duplicate active or recent bugs, questions, or requests
  • I have verified that I am using the latest version of the library.
Step 2: Describe your environment
  • Library version: 3.3.0
  • Android version: 13
  • Support library version: ?
  • Device brand: OnePlus
  • Device model: 7T
Step 3: Describe the problem:
Steps to reproduce:
  1. Activate TalkBack
  2. Open the action menu
Observed Results:
  • The labels are read twice, once for the actual text labels and once for the FAB images. TalkBack users have to swipe twice to get to the next item because each item is focused twice.
Expected Results:
  • Read and focus each action only once.
Relevant Code:

I think this was introduced in https://github.com/leinardi/FloatingActionButtonSpeedDial/commit/6653f9182323add0624d593432e1c33f71c7b0d0, which sets a content description on the FABs even if there already is a label anyway. Instead, if there is a label, it should set the FAB to be not important for accessibility.

See also: https://github.com/AntennaPod/AntennaPod/issues/6692

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting commit 6653f9182323add0624d593432e1c33f71c7b0d0 and the FAB/action-menu implementation it changed. Reproduce the issue with TalkBack on Android 13, then verify that each action is focused and its label is read only once.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
accessibility, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.